More cgtop enhancements #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly flush stdout before sleep between iterations - Only clear user keystrokes when output is to TTY - Add a newline between output batches when output is not to TTY
|
This also exists as #3; I suggest that this (imported-from-mail) version be closed in favor of the other. |
|
(One addition to this patchset not present when it was last submitted to the mailing list is 5e688f7; as I understand that Github is being used to drive the review and merge process going forward, is adding it to the PR here appropriate, or should this be brought up on the ML?) |
|
I'll close this in favor of #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: Charles Duffy chaduffy@cisco.com
In addition to the previously-submitted patch adding support for "raw" (numeric
byte-count, as opposed to human-readable) values, this series adds several new
enhancements:
TTY, but allow endless looping or a set iteration count to be selected.
batches with an empty line, rather than the de facto "\r \r" string intended
to clear artifacts from user input, and ensuring that flushing stdout happens
before the sleep between runs).
The strftime support, by its nature, requires use of an externally-provided
format string; consequently, an appropriate pragma is used to suppress warnings
from gcc. Feedback appreciated.