make gpt flag 59 (growfs) actually work on the root fs #30030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
please-review
|
An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
poettering
force-pushed
the
gpt-growfs-root-fix
branch
from
7fccb14
to
e5154eb
Compare
YHNdnzj
approved these changes
Nov 15, 2023
YHNdnzj
added
good-to-merge/with-minor-suggestions
and removed
please-review
This call is never called in the initrd, hence we can drop the extra check, as it is redundant. Let's keep it as an assert() though, as a form of code-enforced documentation.
We are not invoked in the initrd, and that deserves a comment.
…s_service() I cannot see a reason why we should ignore this error, so let's not. We use RET_GATHER() on the returns anyway, i.e. collect errors but continue, so it makes sense to collect this one too.
poettering
force-pushed
the
gpt-growfs-root-fix
branch
from
e5154eb
to
6b5fe5d
Compare
poettering
added
good-to-merge/waiting-for-ci 👍
|
An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
|
Is it realistic to have this backported to v253/v254? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29791
Fixes: #28133