Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort input file list #31080

Merged
merged 1 commit into from Jan 25, 2024
Merged

Sort input file list #31080

merged 1 commit into from Jan 25, 2024

Conversation

bmwiedemann
Copy link
Contributor

Sort input file list
so that /usr/lib/systemd/tests/unit-tests/test-libsystemd-sym builds in a reproducible way
in spite of non-deterministic filesystem readdir order.

See https://reproducible-builds.org/ for why this is good.

This patch was done while working on reproducible builds for openSUSE.

so that /usr/lib/systemd/tests/unit-tests/test-libsystemd-sym
builds in a reproducible way
in spite of non-deterministic filesystem readdir order

See https://reproducible-builds.org/ for why this is good.

This patch was done while working on reproducible builds for openSUSE.
@github-actions github-actions bot added tests please-review PR is ready for (re-)review by a maintainer labels Jan 25, 2024
@yuwata yuwata added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review PR is ready for (re-)review by a maintainer labels Jan 25, 2024
@bluca bluca merged commit ac0054e into systemd:main Jan 25, 2024
45 of 49 checks passed
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jan 25, 2024
@bluca
Copy link
Member

bluca commented Jan 25, 2024

There's one more arm-specific reproducibility problem, does your infra test on that architecture too?

@bluca
Copy link
Member

bluca commented Jan 25, 2024

There's one more arm-specific reproducibility problem, does your infra test on that architecture too?

Specifically: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/diffoscope-results/systemd.html

somehow, arm_fadvise64_64 shows up in the second build armhf build of libsystemd-shared-255.so and I have no clue why or how

@bmwiedemann bmwiedemann deleted the sort branch January 25, 2024 10:42
@bmwiedemann
Copy link
Contributor Author

I did not test ARM so far because I don't have the hardware available to build. I'm running a test for openSUSE/armv7l systemd with qemu emulation atm.

@bluca
Copy link
Member

bluca commented Jan 25, 2024

Seems like we figured it out, it's a problem in the handling of the kernel architecture in src/shared/generate-syscall-list.py

@bmwiedemann
Copy link
Contributor Author

My tests already gave me two bit-identical rpms for armv7l (with reduced non-determinism).

It is good that you found the source.

@bluca
Copy link
Member

bluca commented Jan 25, 2024

Thanks for checking! The issue I had was because one of the armv7 builds was done on an arm64 kernel, so it threw the script off balance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants