gcrypt: dlopenify for libsystemd #32019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
network
journal
resolve
build-system
util-lib
tests
meson
please-review
YHNdnzj
reviewed
Mar 30, 2024
poettering
reviewed
Apr 2, 2024
poettering
reviewed
Apr 2, 2024
poettering
reviewed
Apr 2, 2024
poettering
reviewed
Apr 2, 2024
teknoraver
approved these changes
Apr 3, 2024
DaanDeMeyer
requested changes
Apr 3, 2024
DaanDeMeyer
added
good-to-merge/with-minor-suggestions
and removed
please-review
gcrypt is used only for journal sealing operations in libsystemd, so it can be made into a dlopen dependency that is used only on demand. This allows to reduce the footprint of libsystemd in the most common cases. Keep systemd-pull and systemd-resolved with normal linking, as they are executables, and usually built with OpenSSL support anyway.
bluca
added
good-to-merge/waiting-for-ci 👍
|
Would be great that whenever a library is dlopened (for the first time), a log message (info) is sent to the journal. |
info would be too verbose, as every time a binary is called you'd get the message, but we can add a debug one for sure |
-> #32065 |
|
lgtm |
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
aafeijoo-suse
added a commit
to aafeijoo-suse/dracut
that referenced
this pull request
Apr 4, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019 Closes dracutdevs#2642
aafeijoo-suse
added a commit
to aafeijoo-suse/dracut
that referenced
this pull request
Apr 4, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019
aafeijoo-suse
added a commit
to aafeijoo-suse/dracut
that referenced
this pull request
Apr 4, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019
dracutng
pushed a commit
to dracutng/dracut-ng
that referenced
this pull request
Apr 6, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019 Closes #2642
Conan-Kudo
pushed a commit
to dracut-ng/dracut-ng
that referenced
this pull request
Apr 8, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019 Closes #2642
pvalena
pushed a commit
to pvalena/dracut-fedora
that referenced
this pull request
May 15, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019 Closes #2642
pvalena
pushed a commit
to redhat-plumbers/dracut-fedora
that referenced
this pull request
May 15, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019 Closes #2642
pvalena
pushed a commit
to pvalena/dracut-fedora
that referenced
this pull request
May 16, 2024
…y included Some required libraries that used to be statically included are in the process to be opened via `dlopen()`. References: - systemd/systemd#31131 - systemd/systemd#31550 - systemd/systemd#32019 Closes #2642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcrypt is used only for journal sealing operations in libsystemd, so it can be made into a dlopen dependency that is used only on demand. This allows to reduce the footprint of libsystemd in the most common cases.
Keep systemd-pull and systemd-resolved with normal linking, as they are executables, and usually built with OpenSSL support anyway.