Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
man: document that using sd_journal APIs might cause dlopen to happen and add self-contained notify protocol example #32030
man: document that using sd_journal APIs might cause dlopen to happen and add self-contained notify protocol example #32030
Changes from all commits
5aa8180
383917a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the rationale for documenting this? this seems to be somewhat of an implementation detail of things, and we usually don't document these.
Also, isn't this kinda incomplete? Are you sure, sd-jounral is the only API that does this, and that the list is complete?
I'd be more comfortable if this was auto-generated and thus always correct, but this seems a bit random to me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, it'd work better as its own PR. It doesn't fit naturally in this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add it: if people don't know/think about dlopen, they can be quite confused. It applies to all of libsystemd though. This would fit much better in libsystemd(3), in the NOTES section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale is that with the switch of various libs to dlopen, it will be harder to understand who does what in the public library when external programs link to it and call its APIs. In the abscence of a better way to inspect this, documenting it is the least we can do.
And I put it in sd-journal intentionally to clarify the scope: we know that it's only the sd-journal component of the library that loads these, so it's a safe and stable declaration that we can make, so that users don't get the impression that, say, using sd_bus for their dbus calls also results in these dlopens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought, based on https://mastodon.social/@pid_eins/112202687764571433, using this library just for notify is not recommended? @poettering