vmspawn: check firmware target architecture #32224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vmspawn
please-review
poettering
added
good-to-merge/waiting-for-ci 👍
|
Shouldn't this look for the image's architecture rather than the native one? |
Currently vmspawn does not support images which aren't the native architecture. |
YHNdnzj
reviewed
Apr 11, 2024
YHNdnzj
reviewed
Apr 11, 2024
YHNdnzj
added
good-to-merge/with-minor-suggestions
and removed
good-to-merge/waiting-for-ci 👍
sam-leonard-ct
force-pushed
the
vmspawn/better_firmware_selection
branch
from
8f44c9c
to
995b104
Compare
YHNdnzj
added
good-to-merge/waiting-for-ci 👍
yuwata
requested changes
Apr 11, 2024
yuwata
added
good-to-merge/with-minor-suggestions
and removed
good-to-merge/waiting-for-ci 👍
Fixes issue systemd#32026 by only finding firmwares which explicitly support the native architecture.
sam-leonard-ct
force-pushed
the
vmspawn/better_firmware_selection
branch
from
995b104
to
16ca475
Compare
yuwata
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #32026 by only finding firmwares which explicitly support the native architecture.