test: Don't keep journals for skipped tests #32681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
please-review
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
bluca
approved these changes
May 7, 2024
bluca
added
good-to-merge/waiting-for-ci 👍
|
Added one more commit that adds a one liner to download view a test's journal |
bluca
approved these changes
May 7, 2024
bluca
added
ci-fails/needs-rework 🔥
DaanDeMeyer
force-pushed
the
skipped-no-journal
branch
from
9cf9ab0
to
497fb00
Compare
github-actions
bot
added
please-review
bluca
added
good-to-merge/waiting-for-ci 👍
DaanDeMeyer
force-pushed
the
skipped-no-journal
branch
3 times, most recently
from
bbb6722
to
5637dde
Compare
|
Added two more commits to allow marking tests as slow and skipping them unless slow-tests is enabled or SYSTEMD_SLOW_TESTS=1 is set and marked TEST-21-DFUZZER as slow. |
bluca
approved these changes
May 7, 2024
Let's make sure we don't save journals for tests that were skipped.
DaanDeMeyer
force-pushed
the
skipped-no-journal
branch
from
2a7b9ec
to
8ee791e
Compare
Some integration tests take much more time than others, let's add a test param that can be used to configure this and integrate it with the slow-tests meson option.
The test is not really useful without sanitizers, so let's mark it as slow and not run it by default in CI.
DaanDeMeyer
force-pushed
the
skipped-no-journal
branch
from
8ee791e
to
0d13ca5
Compare
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make sure we don't save journals for tests that were skipped.