core/exec-credential: complain louder if inherited credential is missing #32689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also document that a missing inherited credential is not considered fatal. Closes systemd#32667
github-actions
bot
added
documentation
please-review
This comment has been minimized.
This comment has been minimized.
bluca
approved these changes
May 9, 2024
github-actions
bot
removed
the
please-review
|
Hmm, why do this? this doesn't sound right, as i mentioned on the issue earlier: the idea is that services import whatever they want to import from the system, but that we don't require people to also supply this. I mean, for the system creds almost noone will actually provide them. I am pretty sure this should just be reverted. it makes no sense to me at all? i mean, this means that noone will by default unit files that pull in creds anymore because they'd just get a shitlog of warnings then, and what is the value of this? |
|
Silent skip is a bit painful though, when things aren't going the way one expects. Maybe just downgrade to info level? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32667