units: add nosuid and nodev options to tmp.mount #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes privilege escalation attacks harder by putting traps and exploits into /tmp. https://bugs.debian.org/826377
|
these kinds of changes always tend to break a lot of stuff. but ok, let's let this go in but keep a watchful eye. Any chance you can prep a NEWS entry for this already? |
|
Sure! I didn't expect this to get merged that fast :-). So I filed a new PR #3576 for the NEWS update. Thanks! |
Werkov
pushed a commit
to Werkov/systemd
that referenced
this pull request
May 12, 2017
This makes privilege escalation attacks harder by putting traps and exploits into /tmp. https://bugs.debian.org/826377 (cherry picked from commit 2f9df7c)
Werkov
pushed a commit
to Werkov/systemd
that referenced
this pull request
Jun 22, 2017
This makes privilege escalation attacks harder by putting traps and exploits into /tmp. https://bugs.debian.org/826377 (cherry picked from commit 2f9df7c)
mikhailnov
added a commit
to mikhailnov/systemd
that referenced
this pull request
Oct 22, 2019
This reverts commit 2f9df7c. [ compat230 ] Only for max compatibility with behaviour of systemd 230
mikhailnov
added a commit
to mikhailnov/systemd
that referenced
this pull request
Aug 10, 2021
This reverts commit 2f9df7c. [ compat230 ] Only for max compatibility with behaviour of systemd 230 Signed-off-by: Mikhail Novosyolov <m.novosyolov@rosalinux.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes privilege escalation attacks harder by putting traps and exploits into /tmp.
This was pointed out in https://bugs.debian.org/826377: under SysV init, enabling /tmp on tmpfs used these options.
There are a few corner cases where this might break things, such as putting a container overlay into /tmp. But real-world container managers (nspawn, lxc, etc.) already create their own emphemeral overlay mounts and do not depend on /tmp.