Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-sys: move fdset.[ch] src/basic → src/shared #3580

Merged
merged 1 commit into from
Jun 23, 2016

Conversation

poettering
Copy link
Member

It makes use of the sd_listen_fds() call, and as such should live in
src/shared, as the distinction between src/basic and src/shared is that the
latter may use libsystemd APIs, the former does not.

Note that btrfs-util.[ch] and log.[ch] also include header files from
libsystemd, but they only need definitions, they do not invoke any function
from it. Hence they may stay in src/basic.

It makes use of the sd_listen_fds() call, and as such should live in
src/shared, as the distinction between src/basic and src/shared is that the
latter may use libsystemd APIs, the former does not.

Note that btrfs-util.[ch] and log.[ch] also include header files from
libsystemd, but they only need definitions, they do not invoke any function
from it. Hence they may stay in src/basic.
@evverx evverx merged commit 4b7abb5 into systemd:master Jun 23, 2016
@evverx
Copy link
Member

evverx commented Jun 23, 2016

The failure seems unrelated:

Cloning into 'systemd'...
warning: You appear to have cloned an empty repository.
sed: can't read debian/changelog: No such file or directory
blame: https://anonscm.debian.org/git/pkg-systemd/systemd.git
badpkg: rules extract failed with exit code 2

I'm merging.
(I think we should add this note:


    build-sys: split internal basic/ library from shared/

    basic/      can be used by everything
                cannot use anything outside of basic/

    libsystemd/ can use basic/
                cannot use shared/

    shared/     can use libsystemd/

somewhere

poettering added a commit to poettering/systemd that referenced this pull request Jul 25, 2016
Addressing: systemd#3580 (comment)

Also, explain that we focus on glibc, not other libcs's.
poettering added a commit to poettering/systemd that referenced this pull request Jul 25, 2016
Addresses: systemd#3580 (comment)

While we are at it, also document that we focus on glibc, not any other libcs.
@poettering
Copy link
Member Author

@evverx added a comment about the split now to CODING_STYLE in #3802. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants