rules: fix for possible whitespace in the "model" attribute

[msekletar]

Without this the rules would create multiple wrong symlinks, because
SYMLINK treats strings with spaces as a list of links to create.

Suggested-by: Artur Paszkiewicz artur.paszkiewicz@intel.com

[msekletar]

Note that this patch was not tested because, ATM I don't have access to a machine with NVMe drives.

[msekletar]

@kaysievers any chance you could review and possibly merge this?

[keszybz]

Hm, spaces in the SYMLINK option could only come from ID_SERIAL, and ID_SERLIAL should not contain spaces?

[kaysievers]

Hmm, the built-in tools do escaping, to keep the symlink names reversible. I guess we should not mangle the names; so looks like we should add a new mode for string_escape to do do what the other tools are doing to be used for stuff we read from sysfs.

[msekletar]

Hm, spaces in the SYMLINK option could only come from ID_SERIAL, and ID_SERLIAL should not contain spaces?

ID_SERIAL is composed from two parts, ID_SERIAL_SHORT (that shouldn't contain spaces) and from model sysfs attribute and that may contain spaces.

[msekletar]

Hmm, the built-in tools do escaping, to keep the symlink names reversible. I guess we should not mangle the names; so looks like we should add a new mode for string_escape to do do what the other tools are doing to be used for stuff we read from sysfs.

I don't think anyone actually cares about this. I mean you can always look directly at sysfs attribute if you want. IMHO, only thing people care about is symlink being unique and stable.

[msekletar]

@martinpitt you've added needs-rework label. I don't think this is accurate, instead we should make our mind about this issue and either merge this or close it. There is not much to be actually reworked.

Maybe close this in favor of #4837?

[keszybz]

#4837 should handle this.

In fact, we can probably drop OPTIONS="string_escape=replace" from various other places, but that's subject for another PR.

[keszybz]

Oh, we actually don't use string_escape anywhere, because md/dm rules have moved to mdadm ages ago.