shared: recognize DNS names with more than one trailing dot as invalid #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One trailing dot is valid, but more than one isn't. This also fixes glibc's posix/tst-getaddrinfo5 test. Fixes systemd#3978
edolstra
pushed a commit
to NixOS/systemd
that referenced
this pull request
Sep 30, 2016
systemd#4111) One trailing dot is valid, but more than one isn't. This also fixes glibc's posix/tst-getaddrinfo5 test. Fixes systemd#3978. (cherry picked from commit f35c467)
|
Hmpf. This fix looks wrong. dns_label_unescape() is supposed to look at a single label only, but now you make it look one more label ahead... |
|
hmm, i figure the patch is actually Ok after all, even though not particularly pretty. But I figure it's the best we can do, given that dns_label_unescape() is supposed to treat "" and "." the same way, and thus not looking forward will indeed allow a name ending in two trailing dots pass... Sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One trailing dot is valid, but more than one isn't. This also fixes glibc's
posix/tst-getaddrinfo5test.This commit includes unit tests, but I also verified that with the fixed resolved this now works:
Fixes #3978