Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

architecture: Add support for the RISC-V architecture. #4282

Closed
wants to merge 1 commit into from
Closed

architecture: Add support for the RISC-V architecture. #4282

wants to merge 1 commit into from

Conversation

poettering
Copy link
Member

Signed-off-by: Richard W.M. Jones rjones@redhat.com

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
@poettering
Copy link
Member Author

BTW, we don't use S-o-b on systemd, that's a kernel thing. (But this is not a blocking issue, we just prefer patches without).

@poettering
Copy link
Member Author

(This was generated from a patch sent to the ML: https://lists.freedesktop.org/archives/systemd-devel/2016-September/037521.html )

I comented on some issues by mail already:

https://lists.freedesktop.org/archives/systemd-devel/2016-October/037533.html

@poettering poettering added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Oct 4, 2016
@zonque
Copy link
Member

zonque commented Oct 6, 2016

LGTM. @poettering, what is it that needs rework in your opinion?

@poettering
Copy link
Member Author

See mailing list mail: I asked for the cover letter to be included in the patch' own commit msg, and would prefer to exclude the 128bit flavour in the patch since that's apparently just a paper excercise so far.

@rwmjones
Copy link
Contributor

rwmjones commented Oct 7, 2016

It seems to be impossible to update a pull request, or I don't know how. So I opened a new one: #4305

@poettering
Copy link
Member Author

To update a PR simply force push over the branch you submitted, and it will be updated correctly. However, that only works if you filed the initial PR yourself, afaiu. But since I created the github PR from your ML patch that wasn't you in this case. Or in other words: you did the right thing by filing a new PR.

Thanks!

@poettering poettering closed this Oct 7, 2016
@haraldh haraldh deleted the 1475250301-26221-2-git-send-email-rjones@redhat.com branch July 21, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
replaced-by-newer-pr reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks util-lib
Development

Successfully merging this pull request may close these issues.

None yet

3 participants