Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: fix offload features initialization #4639

Merged
merged 1 commit into from Nov 14, 2016
Merged

link: fix offload features initialization #4639

merged 1 commit into from Nov 14, 2016

Conversation

maksqwe
Copy link
Contributor

@maksqwe maksqwe commented Nov 9, 2016

Before fix features are initialized only first 5 bytes.

@keszybz
Copy link
Member

keszybz commented Nov 10, 2016

@maksqwe does this cause some change, or is just a cleanup?

@maksqwe
Copy link
Contributor Author

maksqwe commented Nov 10, 2016

I think that doesn't cause functional change, but it fixes initialization before reading config. Because default proper values for that affload features are -1.

http://cpp.sh/2pz6g
Before: -1, 255, 0, 0, 0
After: -1, -1, -1, -1, -1

@poettering
Copy link
Member

@ssahani can you comment, please?

@ssahani
Copy link
Contributor

ssahani commented Nov 14, 2016

The patch is correct and #4650 should be fixed by this.

@poettering poettering merged commit 45d34fa into systemd:master Nov 14, 2016
@maksqwe maksqwe deleted the offlod_features_ branch January 10, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants