Fix some build issues and warnings #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completely unstested. Fixes systemd#4862.
…CONDARY is We define those macros, and there's no reason to have one without the other.
This is already fixed upstream, so warning is not useful. Let's keep the workaround until the fix has percolated downstream.
The loop must terminate after at most three iterations anyway.
Our warning message was misleading, because we wouldn't "correct" anything, we'd just ignore unkown escapes. Update the message. Also, print just the extracted word (which contains the offending sequences) in the message, instead of the whole line. Fixes systemd#4697.
poettering
reviewed
Dec 11, 2016
| backslash (<literal>\</literal>) may be used to merge lines. | ||
| </para> | ||
| <para>Each command line is split on whitespace, with the first item being the command to | ||
| execute, and the subsequent items being the arguments. Double quotes ("...") and single quotes |
There was a problem hiding this comment.
maybe "..." → "…"? (i.e. unicode ellipsis instead of three dots?)
keszybz
added a commit
to keszybz/systemd
that referenced
this pull request
Dec 11, 2016
As requested in systemd#4864 (review). docbook will substitute triple dots for the ellipsis in man output, so this has no effect on the troff output, only on HTML, making it infinitesimally nicer. In some places we show output from programs, which use dots, and those places should not be changed. In some tables, the alignment would change if dots were changed to the ellipsis which is only one character. Since docbook replaces the ellipsis automatically, we should leave those be. This patch changes all other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.