Allow call_get_os_release to fail #4978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since there's no os to be read from VMs. Without this machinectl would silently abort if libvirt managed QEMU VMs are running. Now we get: $ ./machinectl MACHINE CLASS SERVICE OS VERSION ADDRESSES lxc-12178-sl container libvirt-lxc debian - qemu-3-wheezy vm libvirt-qemu - - 2 machines listed.
|
Looks like #4972 |
|
Closing this one in favour of #4972. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since there's no os to be read from VMs. Without this machinectl would
silently abort if libvirt managed QEMU VMs are running. Now we get:
$ ./machinectl
MACHINE CLASS SERVICE OS VERSION ADDRESSES
lxc-12178-sl container libvirt-lxc debian -
qemu-3-wheezy vm libvirt-qemu - -
2 machines listed.
I've just remove the error checking. If there should be a log_error instead let me know.