Extend the joystick detection #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These buttons were added specifically for joysticks with lots of buttons, no other device should be using them. See kernel commit cf2f765f18960 "HID: handle joysticks with large number of buttons" We only test for BTN_TRIGGER_HAPPY (an alias for BTN_TRIGGER_HAPPY1) here, a device that sets buttons 2 and above but doesn't set 1 is considered buggy. systemd#6137 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Even when they don't have an x/y axis. systemd#6137 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
poettering
reviewed
Jun 22, 2017
src/udev/udev-builtin-input_id.c
Outdated
| @@ -206,6 +206,7 @@ static bool test_pointers(struct udev_device *dev, | |||
| * rudders/pedals are joystick-like, but buttonless; they have | |||
| * other fancy axes */ | |||
| has_joystick_axes_or_buttons = test_bit(BTN_TRIGGER, bitmask_key) || | |||
| test_bit(BTN_TRIGGER_HAPPY, bitmask_key) || | |||
There was a problem hiding this comment.
sounds like a test we should eventually turn into some constant array and for loop...
This was referenced Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything with BTN_TRIGGER_HAPPY should be a joystick, because that's a specific range for joystick buttons.
The more controversial bit is to make anything with joystick buttons or axes as joysticks, even when they don't have ABS_X/ABS_Y. This shouldn't break anything because the ID_INPUT_JOYSTICK tag is added to the tags, nothing is removed. And I can't think of a device that has these axes but no x/y and didn't get already tagged anyway.
#6137