meson: define _GNU_SOURCE to detect copy_file_range() #7734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up for bad7a0c81f501fbbcc79af9eaa4b8254441c4a1f of git repository for glibc. Recently glibc added `copy_file_range()`, but to use it, `_GNU_SOURCE` needs to be defined. This adds the flag in meson.build to detect the function by meson correctly.
yuwata
force-pushed
the
copy_file_range
branch
from
5b653a7
to
6b0d16c
Compare
|
lgtm, though I wonder why we are not setting that unconditionally. I mean, all the new Linux-specific stuff will need this. @keszybz? |
poettering
added
the
good-to-merge/waiting-for-ci 👍
|
|
floppym
pushed a commit
to gentoo/systemd
that referenced
this pull request
Jan 13, 2018
Follow-up for bad7a0c81f501fbbcc79af9eaa4b8254441c4a1f of git repository for glibc. Recently glibc added `copy_file_range()`, but to use it, `_GNU_SOURCE` needs to be defined. This adds the flag in meson.build to detect the function by meson correctly. (cherry picked from commit 0e50bfa)
SergioAtSUSE
pushed a commit
to SergioAtSUSE/systemd_systemd
that referenced
this pull request
Jun 7, 2018
Follow-up for bad7a0c81f501fbbcc79af9eaa4b8254441c4a1f of git repository for glibc. Recently glibc added `copy_file_range()`, but to use it, `_GNU_SOURCE` needs to be defined. This adds the flag in meson.build to detect the function by meson correctly. (cherry picked from commit 0e50bfa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for bad7a0c81f501fbbcc79af9eaa4b8254441c4a1f of git repository for glibc.
Recently glibc adds
copy_file_range()but to use it,_GNU_SOURCEneeds to be defined. This adds the flag in meson.build to detect the function by meson correctly.