timesync: on network event do not establish connection when NTP servers are not changed #8611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs are not changed Fixes systemd#8603.
|
I am not sure this is a right way to fix the issue... |
|
This may also fix #3888. |
|
I like the approach. |
2 tasks
|
@yuwata @poettering You probably want to reconnect periodically (e.g. if you renew a lease and it's a day or more since you last sync'd NTP) but only doing it once per boot for a stable lease could lead to huge drifts that will never be corrected... |
|
@sitsofe I may misunderstand your comment, but timesyncd sends a request after an interval. I do not think this makes timesyncd do 'it once per boot'. |
1 task
|
@yuwata No you understood perfectly and the misunderstanding was mine! You're entirely correct and your patch does indeed look fine :-). |
|
I am happy to hear that :-) |
xnox
pushed a commit
to xnox/systemd
that referenced
this pull request
May 31, 2018
…rs are not changed (systemd#8611) Fixes systemd#8603. (cherry picked from commit 3e85ec0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8603.