Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always rename an interface to its name specified in config #9088

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Always rename an interface to its name specified in config #9088

merged 1 commit into from
Nov 12, 2018

Conversation

cyphermox
Copy link
Contributor

For when no NamePolicy= is specified...

This is intended to fix #9006.

@xnox
Copy link
Member

xnox commented May 25, 2018

Imho explicit user configuration of custom interface names should be honoured.
Imho declarative specification of a custom interface name, should trump a non-declarative one.
Thus explicit names specified in the declarative .link files should be always applied.

+1 from me

fsateler
fsateler requested changes May 25, 2018
View reviewed changes
Copy link
Member

@fsateler fsateler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on wether this is appropriate or not. But after this change should_rename is unused, and thus it should be removed.

@yuwata yuwata added the udev label May 28, 2018
keszybz
keszybz requested changes Jun 4, 2018
View reviewed changes
Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go in, but your patch also changes behaviour in one, I assume, unintended case.

src/udev/net/link-config.c Outdated
case NET_NAME_PREDICTABLE:
/* the kernel claims to have given a predictable name */
if (respect_predictable)
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should stay. I.e. if type == NET_NAME_PREDICATABLE and NAMEPOLICY_KERNEL was specified, the kernel name should be kept.

@poettering poettering added the reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks label Jun 7, 2018
@xnox
Copy link
Member

xnox commented Jul 18, 2018

should_rename is now still used.
name_predictable hunk is now back in.
@keszybz @fsateler is this good to go in now? It looks like the requested changes were done.

@poettering poettering merged commit 55b6530 into systemd:master Nov 12, 2018
@poettering poettering mentioned this pull request Jan 15, 2019
Closed
@keszybz keszybz added merged-but-needs-fixing and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keszybz keszybz keszybz requested changes

@fsateler fsateler fsateler requested changes

Assignees
No one assigned
Labels
merged-but-needs-fixing udev
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

udev: interface name in link file not applied
6 participants
@cyphermox @xnox @keszybz @fsateler @poettering @yuwata