Micmute Key support of ThinkCentre M820z and M920z #9619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a ThinkCentre M800z Micmute Key support entry. But on new models M820z and M920z, the lines must change a bit, the keyboard:name... must change to evdev:name. Already tested on the M820z and M920z hardwares.
|
Quite frankly the existing line simply looks wrong... It's the only entry using the keyboard: prefix, and we generally don't do that. This looks like something where we should just fix the entry by replacing the "keyboard:" prefix by "evdev:", and extend the comment. Can you change things loike that and force push a new version? |
poettering
added
hwdb
reviewed/needs-rework 🔨
Per Poettering's comment in systemd#9619, We better combine M800z and M820/M920z entries and use the "evdev" prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a ThinkCentre M800z Micmute Key support entry.
But on new models M820z and M920z, the lines must change a bit,
the keyboard:name... must change to evdev:name.
Already tested on the M820z and M920z hardwares.