Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Commit

Permalink
allow an @empty plugin module to imply a runtimePlugin
Browse files Browse the repository at this point in the history
  • Loading branch information
guybedford committed Jun 14, 2016
1 parent db4b3a8 commit 5c59fdb
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions lib/trace.js
Expand Up @@ -407,7 +407,11 @@ Trace.prototype.getLoadRecord = function(canonical, traceOpts, parentStack) {
.then(function(pluginNormalized) {
load.plugin = getCanonicalName(loader, pluginNormalized);

if (pluginNormalized.indexOf('!') == -1 && load.metadata.loaderModule.build !== false && getPackage(loader.packages, pluginNormalized)) {
if (load.metadata.loaderModule &&
(load.metadata.loaderModule.build === false || Object.keys(load.metadata.loaderModule).length == 0))
load.runtimePlugin = true;

if (pluginNormalized.indexOf('!') == -1 && !load.runtimePlugin && getPackage(loader.packages, pluginNormalized)) {
var packageConfigPath = getPackageConfigPath(loader.packageConfigPaths, pluginNormalized);
if (packageConfigPath) {
load.pluginConfig = getCanonicalName(loader, packageConfigPath);
Expand All @@ -417,10 +421,8 @@ Trace.prototype.getLoadRecord = function(canonical, traceOpts, parentStack) {
});
})
.then(function() {
if (load.metadata.loaderModule && load.metadata.loaderModule.build === false) {
load.runtimePlugin = true;
if (load.runtimePlugin)
return load;
}

curHook = 'fetch';

Expand Down

0 comments on commit 5c59fdb

Please sign in to comment.