Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

builder.loadConfig must configure plugin loader as well #43

Closed
guybedford opened this issue Jan 12, 2015 · 5 comments
Closed

builder.loadConfig must configure plugin loader as well #43

guybedford opened this issue Jan 12, 2015 · 5 comments

Comments

@guybedford
Copy link
Member

In https://github.com/systemjs/builder/blob/master/index.js#L167, it is just configuring builder.loader, when builder.pluginLoader must also be called with the same configuration.

From #42.

@guybedford
Copy link
Member Author

Fixed in 93566a7.

@martinmicunda
Copy link

@guybedford I tried test your fix and it kind of work however after your fix I am not able to overwrite loader.baseURL in my gulpfile. We have been discussing the reason to overwrite baseUrl in issue #23 see this comment. Thanks

@guybedford
Copy link
Member Author

@martinmicunda I've updated the documentation in https://github.com/systemjs/builder#setting-configuration. You can use a builder.config call here.

@martinmicunda
Copy link

It's working great for me .. thanks

@guybedford
Copy link
Member Author

Excellent, thanks for letting me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants