fix to allow versioned plugins

systemjs · Dec 18, 2014 · 95a9c6b · 95a9c6b
1 parent ca501e8
commit 95a9c6b
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/lib/extension-versions.js b/lib/extension-versions.js
@@ -245,8 +245,9 @@ function versions(loader) {
 
     // strip the version before applying map config
     var stripVersion, stripSubPathLength;
-    if (name.indexOf('@') > 0) {
-      var versionIndex = name.lastIndexOf('@');
+    var pluginIndex = name.lastIndexOf('!');
+    var versionIndex = (pluginIndex == -1 ? name : name.substr(0, pluginIndex)).lastIndexOf('@');
+    if (versionIndex > 0) {
       var parts = name.substr(versionIndex + 1, name.length - versionIndex - 1).split('/');
       stripVersion = parts[0];
       stripSubPathLength = parts.length;

diff --git a/test/test.js b/test/test.js
@@ -22,7 +22,7 @@ function err(e) {
 
 var ie8 = typeof navigator != 'undefined' && navigator.appVersion && navigator.appVersion.indexOf('MSIE 8') != -1;
 
-System.traceurOptions = { asyncFunctions: true };
+System.traceurOptions.asyncFunctions = true;
 
 asyncTest('Error handling', function() {
   System['import']('tests/error-loader').then(err, function(e) {
@@ -373,6 +373,15 @@ asyncTest('Simple compiler Plugin', function() {
   }, err);
 });
 
+asyncTest('Versioned plugin', function() {
+  System.versions['tests/versioned-plugin-test'] = '1.2.3';
+  System['import']('tests/versioned-plugin-test/main').then(function(m) {
+    ok(m.output == 'plugin output');
+    ok(m.versionedPlugin == true);
+    start();
+  }, err);
+})
+
 asyncTest('Mapping to a plugin', function() {
   System.map['pluginrequest'] = 'tests/compiled.coffee!';
   System.map['coffee'] = 'tests/compiler-plugin';

diff --git a/test/tests/plugin@1.2.3/plugin.js b/test/tests/plugin@1.2.3/plugin.js
@@ -0,0 +1,3 @@
+exports.translate = function(load) {
+  load.source += '\nexports.versionedPlugin = true;';
+}
diff --git a/test/tests/versioned-plugin-test@1.2.3/main.js b/test/tests/versioned-plugin-test@1.2.3/main.js
@@ -0,0 +1 @@
+module.exports = require('../compiler-test.coffee!tests/plugin@1.2.3/plugin');