-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative path lookup doesn't work as expected #227
Comments
Breaking test for a bug. For systemjs#227
I've pushed a breaking test to my fork. |
Yes, normalization is name-relative not address-relative. The good news is that names are becoming full URLs, pending ModuleLoader/es-module-loader#218 so then this will work in the next big breaking change coming soon. |
Thanks for patience here... I hate to keep mentioning the elusive updates, but trying to get these changes through in one go if possible. |
Can you make sure there is a test for this bug? I'm not sure why that issue will fix this, if normalization is still name-relative. |
Paths will be renamed to |
Is that a no to adding a test? |
This is not really a bug, this is completely as designed in the current paths model. The model is changing though, and the new model will have tests. |
As long as it is tested! |
@guybedford @matthewp This isn't a bug .. it's a feature. This is a trade off between:
As ES6ML needs to be in the browser, I think it is making a mistake losing the power of a pure normalized namespace for the simplicity of a resource-based moduleNames. |
You should be able to do this:
one.js
It should look up the path to
two
relative to theload.address
ofone
. Instead it tries to loadtwo
from thebaseURL
.If this is a es6-module-loader issue forgive me and I'll file there.
The text was updated successfully, but these errors were encountered: