Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps does not exist #237

Closed
justinbmeyer opened this issue Oct 28, 2014 · 8 comments
Closed

deps does not exist #237

justinbmeyer opened this issue Oct 28, 2014 · 8 comments

Comments

@justinbmeyer
Copy link
Contributor

If you have a meta with an init function, it breaks because deps does not exist here:

https://github.com/systemjs/systemjs/blob/master/lib/extension-global.js#L67

You can see that deps is not in the scope.

@justinbmeyer
Copy link
Contributor Author

cc @matthewp

@guybedford
Copy link
Member

Ok yes that is a bug. PRs welcome.

Note that the init function will be removed in the next major version though.

@justinbmeyer
Copy link
Contributor Author

Why will it be removed? It's super useful.

Sent from my iPhone

On Oct 29, 2014, at 3:58 AM, Guy Bedford notifications@github.com wrote:

Ok yes that is a bug. PRs welcome.

Note that the init function will be removed in the next major version though.


Reply to this email directly or view it on GitHub.

@guybedford
Copy link
Member

I think its use cases are replaced by #190.

@justinbmeyer
Copy link
Contributor Author

Globals can depend on non-globals. For example jQueryUI might depend on jQuery.

Also, without init, I am unable to deal with "document ready" type problems. For example, it's common to want to defer both jQuery's ready event and QUnit from running until all modules have been loaded. This is done in RequireJS's init.

Sent from my iPhone

On Oct 30, 2014, at 7:38 AM, Guy Bedford notifications@github.com wrote:

I think its use cases are replaced by #190.


Reply to this email directly or view it on GitHub.

@justinbmeyer
Copy link
Contributor Author

Also, we've been trying to convince people to upgrade from RequireJS to steal/system. The more similar the config, the easier it is.

Sent from my iPhone

On Oct 30, 2014, at 7:38 AM, Guy Bedford notifications@github.com wrote:

I think its use cases are replaced by #190.


Reply to this email directly or view it on GitHub.

@guybedford
Copy link
Member

I'm keen to get deps working for all module formats in the next release.

@guybedford
Copy link
Member

Finally fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants