Error loading module with assets on Windows

[rmcshane]

Loading a module with assets on Windows fails. This is caused by line 2633:

if (typeof window != 'undefined' && typeof document != 'undefined' && window.location)
  var windowOrigin = location.protocol + '//' + location.hostname + (location.port ? ':' + location.port : '');

In this case, location.protocol = 'file:' which causes problems at line 2687:

if (windowOrigin && address.substr(0, windowOrigin.length) === windowOrigin) {
  address = address.substr(windowOrigin.length);
  dirname = dirname.substr(windowOrigin.length);
}

Which causes address = '/c:/path/to/module'. This eventually causes the module to treat __dirname = 'c:\c:\path\to\module' and loading assets fails.

The following change fixes this issue at line 2633:

if (typeof window != 'undefined' && typeof document != 'undefined' && window.location && location.hostname)
  var windowOrigin = location.protocol + '//' + location.hostname + (location.port ? ':' + location.port : '');

[guybedford]

Thanks for sharing. Does the change:

if (typeof window != 'undefined' && typeof document != 'undefined' && window.location)
  var windowOrigin = location.protocol + '//' + (location.protocol == 'file' && location.hostname[0] != '/' ? '/' : '') + location.hostname + (location.port ? ':' + location.port : '');

also work for you here?

[rmcshane]

That nearly fixes it. The protocol includes a colon, so adding that to the check for a file protocol fixes the issue I noticed:

if (typeof window != 'undefined' && typeof document != 'undefined' && window.location)
  var windowOrigin = location.protocol + '//' + (location.protocol == 'file:' && location.hostname[0] != '/' ? '/' : '') + location.hostname + (location.port ? ':' + location.port : '');

This problem doesn't happen on Mac, or at least doesn't in my environment.

[guybedford]

Excellent, thanks I've included the fix.

[guybedford]

The fix wasn't quite right - I've corrected it in 91b7bc0. Do let me know if you still have any problems here.

[guybedford]

NB this should be ported for 0.18 before the 0.19 release.

[guybedford]

Released in 0.19.0.