Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure onload hooks retain catches #2289

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Ensure onload hooks retain catches #2289

merged 1 commit into from
Dec 15, 2020

Conversation

guybedford
Copy link
Member

The current onload hooks actually alter the promise behaviours in swallowing errors. This corrects those cases.

@github-actions
Copy link

github-actions bot commented Dec 15, 2020

File size impact

Merging fix-onload into master will impact 2 files in 2 groups.

browser (1/2)
File raw gzip brotli Event
dist/system.min.js +16 (11,653) +8 (4,465) +7 (4,022) modified
Total size impact +16 (11,653) +8 (4,465) +7 (4,022)
node (1/1)
File raw gzip brotli Event
dist/system-node.cjs +36 (201,723) +8 (52,190) 0 (43,844) modified
Total size impact +36 (201,723) +8 (52,190) 0 (43,844)
extras (0/8)

No impact on files in extras group.

Generated by file size impact during size-impact#424056975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant