Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid module-types override shouldFetch #2427

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Conversation

wenerme
Copy link
Collaborator

@wenerme wenerme commented Sep 22, 2022

fix #2427

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

File size impact

Merging fix-2426 into main will impact 2 files in 2 groups.

browser (0/2)

No impact on files in browser group.

node (1/1)
File raw gzip brotli Event
dist/system-node.cjs -318,244 (200,342) -74,142 (51,084) -40,329 (43,669) modified
Total size impact -318,244 (200,342) -74,142 (51,084) -40,329 (43,669)
extras (1/8)
File raw gzip brotli Event
dist/extras/module-types.min.js +30 (2,853) +14 (1,231) +13 (1,081) modified
Total size impact +30 (2,853) +14 (1,231) +13 (1,081)
Generated by file size impact during size-impact#3111523246

@guybedford
Copy link
Member

Tests seem to be failing, but happy to land something like this once they are passing.

@wenerme
Copy link
Collaborator Author

wenerme commented Sep 23, 2022

unpkg is too slow to load, changed to jsdeliver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants