Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic import meta placeholder #2431

Merged
merged 1 commit into from Oct 4, 2022
Merged

Conversation

wenerme
Copy link
Collaborator

@wenerme wenerme commented Oct 4, 2022

import assert will going to make into stage 4, add a placeholder for future impl, this may help the module-types extra (will add to core), a placeholder mean the bundler can pass the assertion, but currently only for dynamic import.

for import 'xyz' assert {type:'xyz'}, this maybe harder to decided the how api look.

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

File size impact

Merging import-meta into main will impact 3 files in 2 groups.

browser (2/2)
File raw gzip brotli Event
dist/s.min.js +63 (7,839) +42 (3,111) +33 (2,817) modified
dist/system.min.js +63 (12,173) +39 (4,707) +31 (4,229) modified
Total size impact +126 (20,012) +81 (7,818) +64 (7,046)
node (1/1)
File raw gzip brotli Event
dist/system-node.cjs +254 (519,076) +97 (125,349) -21 (84,148) modified
Total size impact +254 (519,076) +97 (125,349) -21 (84,148)
extras (0/8)

No impact on files in extras group.

Generated by file size impact during size-impact#3181281964

@guybedford guybedford merged commit dd3243d into systemjs:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants