Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx fails when jitsi_meet_server_name was changed #20

Closed
funkyfuture opened this issue Apr 29, 2020 · 6 comments
Closed

nginx fails when jitsi_meet_server_name was changed #20

funkyfuture opened this issue Apr 29, 2020 · 6 comments

Comments

@funkyfuture
Copy link
Contributor

changing jitsi_meet_server_name leads to the situation that there are two website configurations in /etc/nginx/sites-enabled. thus the server_names_hash_bucket_size directive is declared twice and nginx will fail to start.

this could either be fixed by allowing just one site configuration or by factoring that out to an extra configuration file. what would you prefer?

@0x46616c6b
Copy link
Member

We could change the dest in the template step.

  template:
-    dest: "/etc/nginx/sites-available/{{ jitsi_meet_server_name }}.conf"
+    dest: "/etc/nginx/sites-available/jitsi-meet.conf"
      src: nginx/sites-available/vhost.conf.j2
    owner: root
    group: root
    mode: "0644"
  notify: restart nginx

@funkyfuture
Copy link
Contributor Author

yep, if it's intended as single-site deployment.

actually i'm currently figuring out how to fix the prosody config as well.

@funkyfuture
Copy link
Contributor Author

i'm not exactly sure what fixed the latter. i purged prosody and its config to redeploy. eventually the issue described in #11 was effective as well.

i'm probably providing a patch tomorrow.

@0x46616c6b
Copy link
Member

i'm not exactly sure what fixed the latter. i purged prosody and its config to redeploy. eventually the issue described in #11 was effective as well.

i'm probably providing a patch tomorrow.

You need to delete the files under /var/lib/prosody when you purge your installation. Otherwise the old account data is in place and the role will not overwrite them. It is as you mentioned related to #11

funkyfuture added a commit to funkyfuture/ansible-role-jitsi-meet that referenced this issue Apr 30, 2020
This reduces the troubles when the designated web domain is renamed.

Closes systemli#20
funkyfuture added a commit to funkyfuture/ansible-role-jitsi-meet that referenced this issue Apr 30, 2020
This reduces the troubles when the designated web domain is renamed.

Closes systemli#20
funkyfuture added a commit to funkyfuture/ansible-role-jitsi-meet that referenced this issue Apr 30, 2020
This reduces the troubles when the designated web domain is renamed.

Closes systemli#20
funkyfuture added a commit to funkyfuture/ansible-role-jitsi-meet that referenced this issue May 2, 2020
funkyfuture added a commit to funkyfuture/ansible-role-jitsi-meet that referenced this issue May 2, 2020
@0x46616c6b
Copy link
Member

Hey, I would close this issue because the package from Jitsi Meet works with the server name as file name and it would be very complex to change this behaviour. What do you think? Maybe you can try to discuss this upstream with the maintainers of the debian package?

@funkyfuture
Copy link
Contributor Author

i do agree. unfortunately there often too few time to contribute to upstream. maybe it'd make sense to collect a number of issues to make that more fruitful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants