[WIP] Add user api #592
Draft
[WIP] Add user api #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| $user = $this->security->getUser(); | ||
|
|
||
| $aliases = $this->aliasHandler->getEnabledAliasesByUser($user); | ||
| $data = []; |
There was a problem hiding this comment.
You could use array_map here (and similarily in the other controllers) and return it directly. Something along the lines of:
return $this->json(array_map(function (Alias $alias) {
return [
'id' => $alias->getId(),
'address' => $alias->getSource(),
'isRandom' => $alias->getRandom(),
];
}, $aliases), 200);|
|
||
| $data=[ | ||
| 'username' => $user->getEmail(), | ||
| 'mailcrypt_enabled' => $user->hasMailCrypt(), |
There was a problem hiding this comment.
Do we need to expose this via the API? What would be the usecase for a selfservice client? Recovery token would be more useful and important, no?
| @@ -2,8 +2,10 @@ | |||
|
|
|||
| namespace App\Traits; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
These extra empty lines seem like leftovers?
y3n4
force-pushed
the
add_user_api
branch
10 times, most recently
from
082c759
to
b4c91fa
Compare
| #[Route('/api/user/aliases', name: 'get_user_aliases', methods: ['GET'])] | ||
| public function getAliases(): JsonResponse | ||
| { | ||
| $user = $this->security->getUser(); |
There was a problem hiding this comment.
Doesn't it work to use $this->getUser() directly from the parent AbstractController?
y3n4
force-pushed
the
add_user_api
branch
2 times, most recently
from
74c99f4
to
43512fb
Compare
Adds LexikJWT auth bundle and JSON login TODO: Add tests
TODO: - Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.