Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: regex-based implementation of scm.parse #623

Closed
ivotron opened this issue Apr 28, 2019 · 0 comments
Closed

cli: regex-based implementation of scm.parse #623

ivotron opened this issue Apr 28, 2019 · 0 comments
Labels
good first issue

Comments

@ivotron
Copy link
Collaborator

ivotron commented Apr 28, 2019 •
edited

The logic of the scm.parse function is getting a bit too complex to debug. We can implement the same functionality using the re library instead.
This was referenced Jun 6, 2019
Closed
Closed
This was referenced Jun 7, 2019
Closed
Merged
ivotron pushed a commit that referenced this issue May 24, 2020
@JayjeetAtGithub @ivotron
Rewrites scm.parse() with re (#677)
acca747 
fixes #623 
fixes #658
ivotron pushed a commit that referenced this issue May 25, 2020
@JayjeetAtGithub @ivotron
Rewrites scm.parse() with re (#677)
723b4d7 
fixes #623 
fixes #658
ivotron pushed a commit that referenced this issue May 25, 2020
@JayjeetAtGithub @ivotron
Rewrites scm.parse() with re (#677)
a5d80c4 
fixes #623 
fixes #658
ivotron pushed a commit that referenced this issue May 25, 2020
@JayjeetAtGithub @ivotron
Rewrites scm.parse() with re (#677)
218275c 
fixes #623 
fixes #658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivotron