Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite scm.parse() with re #677

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Rewrite scm.parse() with re #677

merged 3 commits into from
Jun 11, 2019

Conversation

JayjeetAtGithub
Copy link
Collaborator

Addresses #623, #658.

@pep8speaks
Copy link

pep8speaks commented Jun 10, 2019

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-06-10 18:29:52 UTC

@JayjeetAtGithub JayjeetAtGithub force-pushed the jayjeet/parser branch 2 times, most recently from 0d22826 to b26fb64 Compare June 10, 2019 12:49
@ivotron ivotron merged commit 39679c1 into master Jun 11, 2019
@ivotron ivotron deleted the jayjeet/parser branch June 11, 2019 05:16
ivotron pushed a commit that referenced this pull request May 24, 2020
ivotron pushed a commit that referenced this pull request May 25, 2020
ivotron pushed a commit that referenced this pull request May 25, 2020
ivotron pushed a commit that referenced this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants