Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Add validations to forms #97

Closed
yatna opened this issue Feb 10, 2017 · 3 comments
Closed

Add validations to forms #97

yatna opened this issue Feb 10, 2017 · 3 comments

Comments

@yatna
Copy link
Member

yatna commented Feb 10, 2017

In various forms there are certain problems. eg in edit profile form-

  1. 'First name' field can be left empty, it should be made mandatory.
  2. 'Mobile Number' allows text too. It should be limited to numbers.
  3. 'Email' field allows invalid emails.
    @medhach I would like to add validations to these forms and send a PR.
@GunpreetAhuja
Copy link

The first name field is automatically filled with username if left blank. So there is no such issue.

@medhach
Copy link

medhach commented Mar 23, 2017

@yatna Send a PR.
@GunpreetAhuja The username and the First name cannot be the same so I think we need to fix it.

@yatna
Copy link
Member Author

yatna commented Aug 28, 2017

Done

@yatna yatna closed this as completed Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants