Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add travis.yml #16

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Add travis.yml #16

merged 1 commit into from
Jul 31, 2018

Conversation

isabelcosta
Copy link
Member

@isabelcosta isabelcosta commented Jul 30, 2018 •
edited
Loading

Description

Adding travis.yml file

Fixes #15

Type of Change:

  • Code

How Has This Been Tested?

Figuring out this now ...

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

m-murad
m-murad suggested changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@m-murad m-murad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not how it's done. Have a look at other Android projects and follow them

m-murad
m-murad reviewed Jul 30, 2018
View reviewed changes
travis.yml Outdated
- platform-tools
- tools
- build-tools-27.0.2
- android-27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a blank line at the end

@isabelcosta
Copy link
Member Author

isabelcosta commented Jul 30, 2018 •
edited
Loading

I did this with very few lines following the Travis CI examples. I was looking at PowerUp and Volunteers, but I saw scripts for generating .apk. Do I have to include that? if yes I have to do the script as well? I'll add the ./gradle assembleDebug line. Also I'm trying to see how to test this before assuming that this is working, is there a way to check this in my Travis account? I'm looking into this. @m-murad

@isabelcosta isabelcosta force-pushed the add-travis-ci branch 3 times, most recently from c2a75f5 to 9b23d90 Compare July 30, 2018 18:52
@isabelcosta
Copy link
Member Author

@m-murad :O :O Not sure if I did all the necessary changes for this to work but I had created travis.yml instead of travis.yml , that for sure was a problem!

m-murad
m-murad reviewed Jul 30, 2018
View reviewed changes
.travis.yml Outdated
before_script:
- chmod +x gradlew
script:
- ./gradlew assembleDebug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, one issue though
change assembleDebug to build

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I saw that on other projects as a comment! I'll change that now! thank you!!! @m-murad

@isabelcosta
Copy link
Member Author

Already passed the build with the assembleDebug -> build change @m-murad

@r00pal r00pal merged commit 66cf3b7 into anitab-org:gsoc18-code Jul 31, 2018
@isabelcosta isabelcosta deleted the add-travis-ci branch July 31, 2018 21:14
@isabelcosta isabelcosta added Program: GSOC Related to work completed during the Google Summer of Code Program. and removed Program: GSOC Related to work completed during the Google Summer of Code Program. labels Aug 12, 2018
m-murad pushed a commit that referenced this pull request Feb 26, 2020
@r00pal
Merge pull request #16 from isabelcosta/add-travis-ci
e3236dc 
Add travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-murad m-murad m-murad approved these changes

@r00pal r00pal r00pal approved these changes

Assignees
No one assigned
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@isabelcosta @m-murad @r00pal