Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentorship Requests and Request Detail Screen #28

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

isabelcosta
Copy link
Member

@isabelcosta isabelcosta commented Aug 9, 2018

Description

Created Mentorship Requests List and the Request Detail screen.

  • Mentorship Requests List has tabs for pending, past and all mentorship relations. One API is called to fetch the list of all mentorship requests, then before setting up the ViewPager fragments, the list are filtered. Each item of the list needs Mentor and mentee keywords, a function to help with this is partially implemented on PR Members List and Member profile #25
  • Request Detail shows the notes, an initial text indicating if the request is sent by the user or received by.
  • 2 buttons for reject and accepting a relation are shown if the relation is in the PENDING state and the end date hasn't passed yet.
  • Delete button shows up if the relationship is in the PENDING state and was sent by me (the current user)
  • A lot of logic for these ^^^ features is done on the RequestDetailActivity (hoping is not too complicated to understand, otherwise I'll add comments to it)
  • Every button perfoms the proper action, accept, reject and delete a mentorship relation

Fixes #9
Fixes #8

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

No tests were implemented yet :/
The UI was tested manually

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings

@isabelcosta isabelcosta added Program: GSOC Related to work completed during the Google Summer of Code Program. DO NOT MERGE labels Aug 9, 2018
@isabelcosta
Copy link
Member Author

Requests screen:

image

Empty requests tab:

image


Detail of request sent by me (with scrollable text view to support small screens)

image


Detail of request a user received (2 buttons to accept or reject)

image


Detail of a request rejected by other users:

image

@isabelcosta
Copy link
Member Author

@systers/maintainers-mentorship-android please review this.

@isabelcosta isabelcosta added Review Requested Program: GSOC Related to work completed during the Google Summer of Code Program. and removed Program: GSOC Related to work completed during the Google Summer of Code Program. labels Aug 11, 2018
@r00pal r00pal merged commit c33433a into anitab-org:gsoc18-code Aug 14, 2018
anny-wu pushed a commit to anny-wu/mentorship-android that referenced this pull request Jan 8, 2020
@isabelcosta isabelcosta deleted the mentorship-relation-list branch February 25, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: GSOC Related to work completed during the Google Summer of Code Program.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants