Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Update README file #1095

Closed
3 tasks
geekanamika opened this issue Mar 30, 2018 · 24 comments · Fixed by #1314
Closed
3 tasks

Update README file #1095

geekanamika opened this issue Mar 30, 2018 · 24 comments · Fixed by #1314

Comments

@geekanamika
Copy link
Contributor

geekanamika commented Mar 30, 2018

Description

As a developer,
I need to update README.md,
so that Information available is consistent with the repository.

Acceptance Criteria

All the following changes will be completed:

  • Remove the link provided in Point 1 under Set up for developers
  • Delete point 5 under Set up for developers
  • Remove step 1 under Configure remotes
  • Update command git merge upstream/master to git rebase upstream/develop
  • Update master branch to develop in the file.
  • Add a point under Set up for developers which directs to build Powerup which is inside the base directory.
  • Change the documentation link under Documentation of PowerUp (Android) to link
  • Correct Code of Conduct link provided in CONTRIBUTING.md

Update [Required]

  • README.md

Definition of Done

  • All of the required items are completed.
  • Approval by 2 mentors.

Estimation

2 hours

Issue discussion : Slack thread

@Rimjhim28
Copy link
Contributor

@geekanamika Looks good to me.

@AjaySharvesh3
Copy link
Contributor

@geekanamika @Rimjhim28 Can I claim this now?

@Rimjhim28
Copy link
Contributor

@AjaySharvesh3 as the label suggests, the issue is for first timers.
Since you have already worked on one of the first timer issue you cannot work on this one.

@AjaySharvesh3
Copy link
Contributor

Oh! Yah, I'm sorry!

@Sabihashaik
Copy link

Hi! I'd like to work on this.

@Rimjhim28
Copy link
Contributor

@Sabihashaik sure! Send a PR.

@Sabihashaik
Copy link

Thanks, I have a question regarding the 6th change. Adding a point which directs to build Powerup. Does that mean I should link it to the build.gradle file in the base directory? I didn't quite get that task.

@geekanamika
Copy link
Contributor Author

geekanamika commented Mar 31, 2018

@Sabihashaik Usually base repo project is the android project, many newcomers make this mistake while building the project. You just have to add a point that will mention "Build powerup(link with if possible) as an android project instead of building the base directory"

Also, I've added one more point at last, please include it in PR.

@Sabihashaik Sabihashaik mentioned this issue Mar 31, 2018
2 tasks
@Sabihashaik
Copy link

@geekanamika Thank you for the clarification. I have sent a PR.

@ghost
Copy link

ghost commented Sep 8, 2018

@geekanamika Is this issue still open? If so can I work on it? I ask because I saw that you changed the status to "Available."

@geekanamika
Copy link
Contributor Author

@Arbalest007 Yes, this issue is available. Go ahead :)

@ghost
Copy link

ghost commented Sep 9, 2018

Awesome thanks! I'll get on it!

@ghost
Copy link

ghost commented Sep 9, 2018

@geekanamika I have a question regarding the first requirement for the README changes. The instructions say to remove the link provided under Point 1 for "Set Up." There are 3 links total - 1 directing to Android Studio's SDK, and 2 referring to links regarding the AD 3.0 Gradle Plugin Migration + Gradle Plugin. Would you like all 3 links to be removed?

@rhythm1705
Copy link

Hey, I would like to contribute to this issue too. Can I please?

@ghost
Copy link

ghost commented Sep 11, 2018

@rhythm1705 I'm not working on this issue anymore so it's up for grabs!

@FIITAY
Copy link

FIITAY commented Oct 13, 2018

hey, can I contribute to this issue?

@FIITAY FIITAY mentioned this issue Oct 13, 2018
3 tasks
@namrata-jha
Copy link
Contributor

Looks like this issue is still open, can I go ahead and work on this issue?

@geekanamika
Copy link
Contributor Author

geekanamika commented Dec 15, 2018

@namrata-jha Refer to PR #1313 . It's almost complete except one required change. @FIITAY hasn't responded since review so you can go ahead & create PR. Let me know if you need any help :)

@namrata-jha
Copy link
Contributor

Yes, I have created a PR, please check.

@Rimjhim28
Copy link
Contributor

@namrata-jha You have already claimed one first timer issue, #1102. You can claim and work on only one first timer issue. I am considering the older one and closing the PR related to this issue.

@namrata-jha
Copy link
Contributor

Alright, I thought I'd claimed so I could do it, sorry for this.

@hridyakrishna
Copy link
Contributor

Hello, Can I please work on this?

@Rimjhim28
Copy link
Contributor

@hsymphonyk The issue is already solved and is not available anymore!
Nevertheless, you can work on other issues!
This is a link to one beginner friendly issue: #1102
You can go ahead and solve any one of the errors.

@hridyakrishna
Copy link
Contributor

@Rimjhim28 Okay. I did not know it. I will try other issues then.

Rimjhim28 pushed a commit that referenced this issue Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
8 participants