Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Fix lint errors #1102

Closed
3 of 20 tasks
Rimjhim28 opened this issue Apr 6, 2018 · 14 comments · Fixed by #1324 or #1334
Closed
3 of 20 tasks

Fix lint errors #1102

Rimjhim28 opened this issue Apr 6, 2018 · 14 comments · Fixed by #1324 or #1334

Comments

@Rimjhim28
Copy link
Contributor

Rimjhim28 commented Apr 6, 2018

Description

As a maintainer,
I need remove the lint errors in the code,
so that the overall code structure and app performance can be improved.

Mocks

Not applicable

Acceptance Criteria

Update

The warnings/error that need to fixed are

  • Android Resource Validation ( 8 errors )
  • Extraneous text in resource file ( 1 waining )
  • Missing commit() on SharedPreference editor ( 4 warnings )
  • Wrong Resource Type ( 4 warnings )
  • Hardcoded text ( 27 warnings )
  • TextView Internationalization ( 18 warnings )
  • Using left/right instead of start/end attributes ( 3 warnings )
  • FrameLayout can be replaced with tag ( 5 warnings )
  • Missing baselineAligned attribute ( 5 warnings )
  • Obsolete layout params ( 5 warnings )
  • Pointless boolean expression ( 4 warnings )
  • Redundant local variable ( 4 warnings )
  • Declaration can have final modifier ( 27 warnings )
  • Method can be void ( 1 warning )
  • Redundant throws clause ( 22 warnings )
  • Unused import ( 40 warnings )
  • 'if' replaceable with 'switch' ( 3 warnings )
  • Unused XML schema declaration ( 5 warnings )

Note : Only of the above listed items can be claimed and fixed by one contributor

Definition of Done

  • One of the required item is completed
  • Approval by 1 mentor.

Estimation

1 hour

@hiatul
Copy link
Contributor

hiatul commented Apr 10, 2018

Can I work on this issue? @Rimjhim28

@Rimjhim28
Copy link
Contributor Author

Rimjhim28 commented Apr 10, 2018

Sure @krshma! You may choose any one of the listed items.
Comment here which warning you are taking up to fix.

@pprathameshmore
Copy link

Can I work on this? @Rimjhim28

@hiatul
Copy link
Contributor

hiatul commented Apr 17, 2018

@Rimjhim28
Hi Rimjhim! I have fixed warnings for unused imports and hardcoded strings.
hiatul@2a3a730

This was referenced Apr 18, 2018
@Rimjhim28
Copy link
Contributor Author

@pprathameshmore As the label clearly specifies that the issue is intended for first time contributors, you cannot claim this since you already have PRs sent to the repository.
Also, you have sent a PR without approval and to fix the error that has already been claimed by @krshma
Please folow instructions and contributing guidelines.

@pprathameshmore
Copy link

Oh! 👍

hiatul added a commit to hiatul/powerup-android that referenced this issue Apr 19, 2018
hiatul added a commit to hiatul/powerup-android that referenced this issue Apr 21, 2018
hiatul added a commit to hiatul/powerup-android that referenced this issue Apr 22, 2018
m-murad added a commit that referenced this issue Apr 23, 2018
@m-murad m-murad reopened this Apr 23, 2018
@smieras
Copy link
Contributor

smieras commented Sep 5, 2018

May I help with the task - Redundant throws clause @Rimjhim28 ?

@Rimjhim28
Copy link
Contributor Author

Sure @smieras! Go ahead and send a PR

@RocknrolliRakacolli
Copy link

May I help with the task "Method Can be Void"?

@Rimjhim28
Copy link
Contributor Author

Sure @RocknrolliRakacolli ! Go ahead and send a PR.

@namrata-jha
Copy link
Contributor

Looks like this issue is still open, can I go ahead and work on this issue?

@namrata-jha namrata-jha mentioned this issue Dec 18, 2018
3 tasks
@Rimjhim28 Rimjhim28 mentioned this issue Dec 20, 2018
3 tasks
@hridyakrishna
Copy link
Contributor

Hello, can I work on this?

hridyakrishna added a commit to hridyakrishna/powerup-android that referenced this issue Jan 21, 2019
hridyakrishna added a commit to hridyakrishna/powerup-android that referenced this issue Jan 28, 2019
@DamianNieves
Copy link

Would it be ok if I tried to fix the "Extraneous text in resource file error."

@Rimjhim28
Copy link
Contributor Author

Sure @DamianNieves! Please go ahead and send a PR.

@Rimjhim28 Rimjhim28 assigned Rimjhim28 and unassigned Rimjhim28 Jan 31, 2019
@Rimjhim28 Rimjhim28 reopened this Jan 31, 2019
@Rimjhim28 Rimjhim28 reopened this Feb 9, 2019
hridyakrishna added a commit to hridyakrishna/powerup-android that referenced this issue Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
9 participants