New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Home Page Slider #199
Added Home Page Slider #199
Conversation
mention mobile testing! |
@ancyp Sure :) |
@ancyp Here is the link for the demo regarding mobile responsiveness of the Home Page Slider: |
@BaaniLeen need not give demo link. I meant just a checklist option for saying - it has been tested on mobile. :) |
The whole Image should fit within the screen (currently have to scroll). The text can go on a black or white background, shrinking image height by 25% as text over image is unreadable. @janiceilene what do you think? |
I agree with the photo going the full width and definitely should be short enough that there's no need to scroll. Didn't we discuss removing those types of images for mobile versions, @BaaniLeen ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly see the comments.
@divyanshu-rawat I have already created a new issue for the responsiveness of the Navbar and the footer and am trying to fix that. |
@BaaniLeen I wil check and let you know 👍 |
src/app/home/home.component.html
Outdated
@@ -1 +1,12 @@ | |||
<h1> HOME PAGE</h1> | |||
<div class=" container box logos mx-auto d-block mt-5 mb-5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! responsive without navbar and footer,
Although Navbar is already fixed in #206
@ancyp Can you please approve and merge this PR. I have made the suggested changes. :) |
Description
Added a slider on the Home Page using Angular carousel, and ngFor to ensure code modularity.
In order to add/remove/change an image, only the image path and description need to be added in the slides array in home.component.ts file, hereon.
Fixes #193
Time Taken :
11 hours (Implementing it + Incorporating Mentor suggestions+ Discussion)
Populating the slider with images in a modular format : 3 hours
Add a timer to automate changing of pictures after a fixed span of time : 3 hours
Add dots below, highlighted dot represents the progress number of the picture- 2 hours
Collecting pictures which can be used on Systers Open Source Home Page slider- 0.5 hours
Creating the Pr - 0.5 hour
Ensure mobile responsiveness - 2 hours.
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
This is the demo of how it looks.
https://drive.google.com/file/d/1agRLN6y3VGXOXlu5wcZnk4jzGrEUGUb_/view?usp=sharing.
Mobile Responsiveness:
https://drive.google.com/file/d/1vS29F8yXYNdNDx7ir9gebBfA_Ro0O6NQ/view?usp=sharing
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only