Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds auto-scroll to footer links #357

Closed
wants to merge 1 commit into from

Conversation

littleBuddhaa
Copy link
Contributor

Description

I created a service which implements auto scroll to top of the page when the contact links in footer is clicked for better user interface. It works when ever a different route changes to /contact route.

fix_auto_scroll

Fixes #356

Type of Change:

Delete irrelevant options.

  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested locally on my machine.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

two
@littleBuddhaa
Copy link
Contributor Author

@BaaniLeen @anumehaagrawal @kanmodi @bethanyr Please review this

Copy link
Contributor

@sarnava1 sarnava1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not supposed to add those pages then it is okay. We can even link them to the links in https://anitab.org/ as you said. What do you think of this @isabelcosta @BaaniLeen @bethanyr?

@anumehaagrawal
Copy link
Contributor

If there are empty links we can link them to https://anitab.org/, But I like the auto scroll implementation when we change routes.

@littleBuddhaa
Copy link
Contributor Author

@anumehaagrawal all the 3 footer links change to contact route for now,could we replace them with https://anitab.org/ footer links and add another 'Contact us' link in the footer for contact route?

@littleBuddhaa
Copy link
Contributor Author

@anumehaagrawal @BaaniLeen Let me know your suggestions, I'll make the changes accordingly :)

@mayburgos
Copy link
Member

We're moving our org to github.com/anitab-org. Please check out the zulip's stream newcomers and create a new topic with your interests. We need a lot of help with updating documentation in the new github repos. :)

@mayburgos mayburgos closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

scroll to top when links in footer are clicked
4 participants