Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate XCM-initiated activites for personal addresses #53

Closed
jensschuppe opened this issue Sep 8, 2021 · 2 comments
Closed

Duplicate XCM-initiated activites for personal addresses #53

jensschuppe opened this issue Sep 8, 2021 · 2 comments
Assignees
@jensschuppe
Labels
bug Something isn't working status:fixed The issue has been resolved (usually by committing/merging code)
Milestone
1.3

Comments

@jensschuppe
Copy link
Collaborator

When no organisation name was provided, but an address, the extension will call the XCM twice, once for creating/identifying the contact (without address) and a second time for passing the address. For configurations with XCM creating addresses for creations and/or updates, multiple activities might be created.

The second call to XCM should be removed and the logic should be reordered so that still:

  • the organisation gets the address, when one was submitted
  • the organisation shares the organisation address with the individual
  • the individual gets the address when no organisation name was submitted
@jensschuppe jensschuppe added the bug Something isn't working label Sep 8, 2021
@jensschuppe jensschuppe added this to the 1.3 milestone Sep 8, 2021
@jensschuppe jensschuppe self-assigned this Sep 8, 2021
jensschuppe added a commit that referenced this issue Sep 8, 2021
@jensschuppe
[#53] Remove duplicate XCM call for individual address
9751e8c
jensschuppe added a commit that referenced this issue Nov 9, 2021
@jensschuppe
Merge branch 'issue/53'
1975639 
[#53] Duplicate XCM-initiated activites for personal addresses
@jensschuppe jensschuppe added the status:fixed The issue has been resolved (usually by committing/merging code) label Nov 9, 2021
@jensschuppe
Copy link
Collaborator Author

Will be released with 1.3 and 1.2.2.

jensschuppe added a commit that referenced this issue Nov 9, 2021
@jensschuppe
[#53] Remove duplicate XCM call for individual address
7ff5d18
@jensschuppe jensschuppe mentioned this issue Nov 16, 2021
Merged
@jensschuppe
Copy link
Collaborator Author

Released with 1.3-beta1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensschuppe jensschuppe

Labels
bug Something isn't working status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
1 participant
@jensschuppe