Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a paragraph to warn users against systopia/de.systopia.xcm#78 #46

Merged
merged 1 commit into from Mar 1, 2021
Merged

Add a paragraph to warn users against systopia/de.systopia.xcm#78 #46

merged 1 commit into from Mar 1, 2021

Conversation

MarcMichalsky
Copy link
Contributor

We recently ran into that problem. Our fundraising team was not amused.

@jensschuppe jensschuppe merged commit 4659b53 into systopia:master Mar 1, 2021
@jensschuppe jensschuppe added the enhancement New feature or request label Mar 1, 2021
@jensschuppe jensschuppe added this to the 1.3 milestone Mar 1, 2021
@jensschuppe
Copy link
Collaborator

Thanks @MarcMichalsky!

@MarcMichalsky MarcMichalsky deleted the issue/XCM_primary_details branch March 1, 2021 13:43
@bjendres
Copy link
Member

bjendres commented Mar 2, 2021

There might be a point in filtering out the country_id before passing it on to the XCM if it would be the only address parameter...

@MarcMichalsky Wouldn't that call for another ticket here?

@jensschuppe
Copy link
Collaborator

One might want to have a reason for recording countries of contacts. If I recall correctly, the user_country parameter was probably meant for distinguishing languages/countries of donors in Twingle and they asked us to process it somehow.

I could imagine handling the user_country parameter as preferred_language instead, but that should be configurable.

@bjendres
Copy link
Member

bjendres commented Mar 2, 2021

In any case, this should be a separate ticket

@MarcMichalsky
Copy link
Contributor Author

If I recall correctly, the user_country parameter was probably meant for distinguishing languages/countries of donors in Twingle and they asked us to process it somehow.

This was the reason why I was so confused. I undesrstood the user_country as localisation information for language etc. and not as an address information. But it also makes perfectly sense to use it when building the address – but not if it's the only address information.

@jensschuppe
Copy link
Collaborator

I undesrstood the user_country as localisation information for language etc. and not as an address information.

If that's the point, this should be called user_language. A country can not be mapped 1:1 to a language (think of Switzerland or Belgium!).

Anyway, is this obsolete with #48 being merged, @MarcMichalsky?

@jensschuppe jensschuppe changed the title add a paragraph to warn users against systopia/de.systopia.xcm#78 Add a paragraph to warn users against systopia/de.systopia.xcm#78 May 2, 2022
@jensschuppe
Copy link
Collaborator

Released with 1.3-beta1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants