Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad translation of 里 #34

Closed
Audman opened this issue Apr 3, 2023 · 3 comments
Closed

Bad translation of 里 #34

Audman opened this issue Apr 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Audman
Copy link

Audman commented Apr 3, 2023

SAVE_20230403_202048.jpg

The main translation is just onyomi of the kanji.
It should be "village" for example.

@syt0r
Copy link
Owner

syt0r commented Apr 4, 2023

Hm, characters info is from kanjidic, but there is also entry in jmdict dictionary for 里 and "ri" actually means "Japanese league, old Japanese unit of distance, approx. 3.927 km or 2.44 miles". I agree that "village" would be more appropriate, though it would require implementing solution to override dictionary priorities

@syt0r syt0r added the enhancement New feature or request label Apr 4, 2023
@Audman
Copy link
Author

Audman commented Apr 20, 2023

Also on topic:
市 should be first "city" and then "town" and "market", because most of it's words mean something related to cities:
Screenshot_2023-04-21-01-43-01-575_ua.syt0r.kanji.fdroid.jpg

Also, Chinese cities end with 市:
Screenshot_2023-04-21-01-45-43-239_com.google.android.apps.maps.jpg

syt0r added a commit to syt0r/Kanji-Dojo-Data that referenced this issue Jan 23, 2024
@syt0r
Copy link
Owner

syt0r commented Jun 28, 2024

里 was fixed, but for 市 I think it can be left as is, other dictionaries also have it in first place

@syt0r syt0r closed this as completed Jun 28, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants