Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other language options (for translation/meaning) #40

Open
adaerr opened this issue May 12, 2023 · 3 comments
Open

Add other language options (for translation/meaning) #40

adaerr opened this issue May 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@adaerr
Copy link

adaerr commented May 12, 2023

It would be nice if the language for the translations could be chosen.

How would one go about this ? I could try to produce a PR, and would welcome any suggestion. What IDE are you using ?

@syt0r
Copy link
Owner

syt0r commented May 13, 2023

You can use either Intellij IDEA or Andorid Studio, but this feature might be quite complicated.

First of all you'll need to check whether there are translations for you langauge for Kanji Dic and JMDict or find other source for translations.
Then it would be required to update parser module and database schema to support multiple languages
After updating database schema app should be updated as well to support multiple languages for translations
Also it might make database 2 times bigger and I would like to avoid this since most users might not use your language at all, so it would require some solution to dynamically load additional language packs

Btw, here is user distribution by device languages:
image

@syt0r syt0r added the enhancement New feature or request label May 13, 2023
@adaerr
Copy link
Author

adaerr commented May 15, 2023

I see, thanks for the explanations, it does indeed seem more complicated to add than I thought. There is a multi-lingual version of the JMDict (the EDICT wiki mentions glosses in "German (133,000 entries), Russian (80,000), Hungarian (51,000), Spanish (39,000), Dutch (29,000), Swedish (16,000), French (15,000) and Slovenian (9,000)), and KANJIDIC also has other translations already included, but I acknowledge that this bloats the database, and the number of users who would use these alternative translations is not clear. The device language statistics give IMHO only lower bounds for non-english speaking users; my device came running in english by default, and I just never bothered changing that language.

One solution may be to start with the full multi-language versions of JMDict and KANJIDIC, and import into the database only the language of interest (keeping english as fallback where no other glosses are found). It seems to me that would require only modifying the parser, the database and the rest of the app would not need changing. Forces a reinstall to change the language, but I could live with that.

@ThomasLeigh
Copy link

@syt0r , @adaerr

One solution may be to start with the full multi-language versions of JMDict and KANJIDIC, and import into the database only the language of interest

Any chances to implement this idea? Kanji Dojo is, imo, significantly above other similar apps, given how well-thought is made, its aesthetic, and so on. It could be of a great value to be able to reach also non-English users with this app. Surely there are many of them wanting to learn Japanese, but not English. If there is a chance for it to be done without some great hassle, please do that and let all the rest of the world cherish and value this great, great app, which is a tool of a huge value in terms of learning Japanese (imo).

Another way is just to allow users to add their own labels to any character they want, which should be displayed before or instead the current English labels. This could allow both various translations (which can be spread via backup files) and incorporating mnemotechnics which 1) for many students may be essential in character learning and 2) it works best if tailored individually (if anyone can add their own).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants