Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setting non-image files as avatar/banner #2511

Merged
merged 4 commits into from
Aug 27, 2018
Merged

Prevent setting non-image files as avatar/banner #2511

merged 4 commits into from
Aug 27, 2018

Conversation

Hiramiya
Copy link
Contributor

Depends on/includes previous PR: syuilo/misskey/pull/2509

This PR prevents using file extensions other than commonly used image extensions as an avatar or banner. This does not stop files with incorrect extensions, but does prevent accidental changes.

Submitting as a fix for syuilo/misskey/issues/2096, however will require additional localisation

@syuilo syuilo merged commit 77baca8 into misskey-dev:develop Aug 27, 2018
@syuilo
Copy link
Member

syuilo commented Aug 27, 2018

👍👍👍

@Hiramiya
Copy link
Contributor Author

@syuilo can you add

desktop:
  invalid-filetype:

to CrowdIn? Originally added it directly in a commit

Thanks!

@syuilo
Copy link
Member

syuilo commented Aug 29, 2018

Added! (It may take several minutes to be reflected)

nokotaro pushed a commit to nokotaro/misskey that referenced this pull request Aug 15, 2021
Bumps [vue-i18n](https://github.com/kazupon/vue-i18n) from 8.24.3 to 8.24.4.
- [Release notes](https://github.com/kazupon/vue-i18n/releases)
- [Changelog](https://github.com/kazupon/vue-i18n/blob/v8.x/CHANGELOG.md)
- [Commits](kazupon/vue-i18n@v8.24.3...v8.24.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants