Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 for invalid Object ID #3627

Merged
merged 7 commits into from
Dec 15, 2018
Merged

Return 404 for invalid Object ID #3627

merged 7 commits into from
Dec 15, 2018

Conversation

mei23
Copy link
Contributor

@mei23 mei23 commented Dec 15, 2018

Resolve #3625
関連 #3621

ActibityPubで
以下のURIのように不正なObjectIDで要求された時に500でなく404を返すように修正しています

/notes/InvaliedID
/notes/InvaliedID/activity
/users/InvaliedID
/users/InvaliedID/publickey
/users/InvaliedID/followers
/users/InvaliedID/following
/users/InvaliedID/outbox
/users/InvaliedID/collections/featured

@syuilo syuilo merged commit ffb80ef into develop Dec 15, 2018
@syuilo
Copy link
Member

syuilo commented Dec 15, 2018

🙏🙏🙏

@AyaMorisawa AyaMorisawa deleted the acid-chicken-patch-5 branch December 20, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo approved these changes

@acid-chicken acid-chicken acid-chicken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mei23 @syuilo @acid-chicken