[utils] dependencyInfo: use child_process instead of shelljs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop shelljs from dependencies.
otofune
changed the title
syuilo
approved these changes
Jan 25, 2017
|
Thanks! |
syuilo
referenced
this pull request
Jan 26, 2017
Steve-0628
pushed a commit
to Steve-0628/misskey
that referenced
this pull request
Mar 14, 2023
u1-liquid
pushed a commit
to u1-liquid/misskey
that referenced
this pull request
Jun 15, 2023
Merge v13.11.1
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Nov 24, 2023
Kesefon
pushed a commit
to Kesefon/misskey
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop shelljs from dependencies.
代わりにchild_process.execSyncを使います。今まで通り同期処理。
オプションの
stdio: ['pipe', 'pipe', 'ignore']はステータス0以外のときにexecSyncはstderrをコンソール上に出力してしまうのでプロセスからのstderrをすべて無視するようにセットしています。参照: https://nodejs.org/api/child_process.html#child_process_options_stdio