Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass RuntimeContext on creating Go instance #84

Merged
merged 3 commits into from
Jan 4, 2024
Merged

pass RuntimeContext on creating Go instance #84

merged 3 commits into from
Jan 4, 2024

Conversation

syumai
Copy link
Owner

@syumai syumai commented Jan 4, 2024 •
edited

What

  • pass RuntimeContext on creating Go instance.
  • add binding object to RuntimeContext.

Motivation

  • To improve APIs depend on RuntimeContext. e.g. cloudflare.Getenv(ctx, name) to cloudflare.Getenv(name).
  • To prevent dependence on setting a value to a global object.

@syumai syumai self-assigned this Jan 4, 2024
@syumai syumai changed the title pass RuntimeContext on create Go instance pass RuntimeContext on creating Go instance Jan 4, 2024
@syumai syumai merged commit 7529cef into main Jan 4, 2024
1 check passed
@syumai syumai deleted the pass-runtime-context-on-create-go-instance branch January 4, 2024 15:04
@syumai syumai mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@syumai syumai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@syumai