chore: bump tap major to 14.x #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saved this for last so I could isolate any project changes required for the tap upgrade.
Until I added the
.taprcfile, tests were passing locally but failing in CI, which I was able to duplicate locally by piping the tap run output toless.I think the problem was that
FORCE_COLOR=1used to be picked up by tap (v12) from the parent env and passed down to the env of each child process, but it looks like tap changed that (v14).I "fixed" the way I was running tap by using the
test-envconfig property in.taprc. Seems to work consistently across TTY and non-TTY now.